deps: update to latest chrome-devtools-frontend #15137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Jun 9, 2023
| @@ -44,6 +44,7 @@ describe('Deprecations audit', () => { | |||
| }, | |||
| }, | |||
| { | |||
| // Does not exist anymore. | |||
There was a problem hiding this comment.
Why keep this around, doe we still need to handle it gracefully in older Chrome versions?
There was a problem hiding this comment.
Including a type that used to exist but no longer does is a minor but possibly useful test case (minor, because it is pretty equivalent to a type that never existed). I didn't see a reason to remove it, but you're right it is not immensely valuable.
Note that there is no deprecation message for this event now. It's treated exactly like a type that we don't know about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change here is that the deprecation strings in CDT frontend got split across two files and refactored a bit. I responded by grabbing the file that just had the strings (as usual), but for
getIssueDetailDescriptionI just manually rewrote it (not worth automating that).